Ruby: Support erb flow for ActionController #15555
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the existing modeling for ViewComponent to ActionController. The `render` method in ActionController behaves in a similar way except that the ERB file is evaluated in the context of the controller class, rather than a separate view class. This means we need the value of `self` at the `render` call to flow to the `self` in the ERB file.
hmac
force-pushed
the
erb-steps-for-actioncontroller
branch
from
59386be to
16639bc
Compare
hmac
force-pushed
the
erb-steps-for-actioncontroller
branch
from
eac9716 to
4b31302
Compare
hvitved
reviewed
Apr 18, 2024
| or | ||
| input = "Argument[self]" and | ||
| output = "Argument[self].Parameter[self]" and | ||
| preservesValue = true |
There was a problem hiding this comment.
I think we may need to synthesize a new set of render summaries, where we record the name of the ActionControllerActionMethod that calls it. Something like
private class ActionRenderMethod extends SummarizedCallable, LibraryCallableToIncludeInTypeTracking {
private ActionControllerActionMethod m;
RenderMethod() { this = "render view component " + m.getName() }
override MethodCall getACallSimple() { result.getMethodName() = "render" and result.getEnclosingCallable() = m}
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
// use a call-back summary, and adjust it to a method call below
input = "Argument[self]" and
output = "Argument[self].Parameter[self]" and
preservesValue = true
}
}Then adjustedMethodCall needs to updated to include the name as well, and finally lookupMethodCall can be replaced with something that looks more like the existing Toplevel lookupMethod(ViewComponent::ComponentClass m, string name).
There was a problem hiding this comment.
Hmm, I realize that this may not work because of non-monotonicity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same approach as with ViewComponent, to track flow into ERB template files via explicit
rendercalls.We don't yet deal with:
renderthat change the templaterenderat return nodes of action methods